Manually delete cacheFile before we write to it #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What use cases does this fix? It seems like if we're not able to write to the file, we wouldn't be able to delete it either. |
|
If the cacheFile exists, when we call |
|
Ah I see. LGTM! |
wangmengyan95
added a commit
that referenced
this pull request
Sep 10, 2015
…FileController_delete_cache_file_before_move_temp_file Manually delete cacheFile before we write to it
wangmengyan95
deleted the
wangmengyan.t8184922_ParseFileController_delete_cache_file_before_move_temp_file
branch
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.